Conversation
This was referenced Apr 22, 2026
starr-openai
approved these changes
Apr 22, 2026
Contributor
starr-openai
left a comment
There was a problem hiding this comment.
cc @viyatb-oai since you were also working on this recently
viyatb-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a cleanup PR for the
PermissionProfilemigration stack. #19016 fixed remote exec-server sandbox contexts so Docker-backed filesystem requests use a request/containercwdinstead of leaking the local test runnercwd. That exposed the broader API problem:FileSystemSandboxContext::new(SandboxPolicy)could still reconstruct filesystem permissions by reading the exec-server process cwd withAbsolutePathBuf::current_dir().That made
cwd-dependent legacy entries, such as:cwd,:project_roots, and relative deny globs, depend on ambient process state instead of the request sandboxcwd. As later PRs makePermissionProfilethe primary permissions abstraction, sandbox contexts should be explicit about whether they carry a requestcwdor are profile-only. Removing the implicit constructor prevents new call sites from accidentally rebuilding permissions against the wrongcwd.What changed
FileSystemSandboxContext::new(SandboxPolicy).from_legacy_sandbox_policy(..., cwd),from_permission_profile(...), andfrom_permission_profile_with_cwd(...).PermissionProfilevalues directly instead of routing through legacySandboxPolicyprojections.cwd.Verification
cargo test -p codex-exec-serverjust fix -p codex-exec-serverStack created with Sapling. Best reviewed with ReviewStack.