Conversation
dylan-hurd-oai
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19266.
Why
thread_start_with_non_local_thread_store_does_not_create_local_persistenceis meant to catch accidental local thread persistence when a non-local thread store is configured. The Windows flake reported in this BuildBuddy invocation showed that the assertion was tripping on an unexpected top-level.tmpentry:{ + ".tmp", "config.toml", "installation_id", "memories", "skills", }That
.tmpdoes not appear to come fromtempfile::TempDir; it comes from unrelated plugin startup work that can legitimately materializecodex_home/.tmp, including the startup remote plugin sync marker incore/src/plugins/startup_sync.rsand the curated plugin snapshot under.tmp/plugins.That makes the regression race unrelated background startup tasks instead of validating the thread-store invariant it was added to cover. Rather than weakening the assertion to allow arbitrary
.tmpentries, this change isolates the test from plugin warmups so it can stay strict about unexpected local thread persistence artifacts.What changed
app-server/tests/suite/v2/remote_thread_store.rscodex_homeassertions unchanged so the test still fails if local session or sqlite persistence is introducedVerification
cargo test -p codex-app-server suite::v2::remote_thread_store::thread_start_with_non_local_thread_store_does_not_create_local_persistence -- --exact