Fix log db batch flush flake#19959
Merged
dylan-hurd-oai merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
rasmusrygaard
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The log DB writer batches tracing events before inserting them into SQLite, but
tokio::time::intervalproduces an immediate first tick. That meant the inserter could flush the first accepted log entry beforebatch_sizewas reached, makingconfigured_batch_size_flushes_without_explicit_flushtiming-sensitive in CI.What Changed
Validation
cargo test -p codex-statecargo test -p codex-state configured_batch_size_flushes_without_explicit_flushpassed 3 consecutive focused runsrust-ci, Bazel,ci,sdk,cargo-deny, Codespell, blob-size policy, and CLA