Skip to content

Fix log db batch flush flake #19959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-hurd-oai merged 1 commit into from
Apr 28, 2026
+2 −1
Merged

Fix log db batch flush flake #19959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codex-rs/state/src/log_db.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ async fn run_inserter(
) {
let mut buffer = Vec::with_capacity(config.batch_size);
let mut ticker = tokio::time::interval(config.flush_interval);
// Consume the immediate startup tick so entries flush after the interval.
ticker.tick().await;
loop {
tokio::select! {
maybe_command = receiver.recv() => {
Expand Down Expand Up @@ -645,7 +647,6 @@ mod tests {
flush_interval: std::time::Duration::from_secs(60),
},
);
tokio::time::sleep(std::time::Duration::from_millis(10)).await;

let guard = tracing_subscriber::registry()
.with(
Expand Down
Loading