Fix Windows pseudoconsole attribute handling for sandboxed PTY sessions#20042
Merged
Fix Windows pseudoconsole attribute handling for sandboxed PTY sessions#20042
Conversation
iceweasel-oai
changed the title
iceweasel-oai
force-pushed
the
codex/windows-pseudoconsole-attribute-handle
branch
from
c589b1c to
00e6a07
Compare
jif-oai
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows sandbox PTY spawn path to pass the pseudoconsole handle value directly into
UpdateProcThreadAttribute.Why
Sandboxed
unified_execPTY sessions on Windows were failing during child process startup with0xc0000142(STATUS_DLL_INIT_FAILED). In practice this showed up as PowerShell DLL init popups when the sandboxed background-terminal path tried to launch an interactive shell.The root cause was that we were passing a pointer to a local
isizevariable instead of the pseudoconsole handle value in the form Windows expects forPROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE.Validation
cargo build -p codex-windows-sandbox --binscodex execflow withwindows.sandbox_private_desktop=truetty=trueinteractive session launched through the normal PowerShell wrapper, printedREADY, accepted follow-up stdin, and exited cleanly0xc0000142/Application Popupevents appeared after the successful repro