Skip to content

Fix Windows pseudoconsole attribute handling for sandboxed PTY sessions #20042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jif-oai merged 2 commits into from
Apr 29, 2026
+3 −3
Merged

Fix Windows pseudoconsole attribute handling for sandboxed PTY sessions #20042

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2229ece
fix Windows pseudoconsole attribute handle
iceweasel-oai Apr 28, 2026
00e6a07
cargo fmt
iceweasel-oai Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions codex-rs/windows-sandbox-rs/src/proc_thread_attr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::ffi::c_void;
use std::io;
use windows_sys::Win32::Foundation::GetLastError;
use windows_sys::Win32::Foundation::HANDLE;
Expand Down Expand Up @@ -45,14 +46,13 @@ impl ProcThreadAttributeList {

pub fn set_pseudoconsole(&mut self, hpc: isize) -> io::Result<()> {
let list = self.as_mut_ptr();
let mut hpc_value = hpc;
let ok = unsafe {
UpdateProcThreadAttribute(
list,
0,
PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE,
(&mut hpc_value as *mut isize).cast(),
std::mem::size_of::<isize>(),
hpc as *mut c_void,
std::mem::size_of::<HANDLE>(),
std::ptr::null_mut(),
std::ptr::null_mut(),
)
Expand Down
Loading