Thread Windows metadata targets through setup request#21031
Conversation
1fef4bd to
df461fd
Compare
d4a25ea to
f29e31e
Compare
df461fd to
b4cb7cf
Compare
f29e31e to
230dcf4
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 230dcf45c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elevated_read_roots_include_platform_defaults, | ||
| write_roots_override: elevated_write_roots_override.as_deref(), | ||
| deny_write_paths_override: &elevated_deny_write_paths, | ||
| protected_metadata_targets: &[], |
There was a problem hiding this comment.
Pass protected metadata targets to elevated setup
resolve_windows_*_filesystem_overrides populates protected_metadata_targets, but the elevated capture request is always given &[] here. Any split policy metadata protections are dropped before setup/refresh, so the elevated backend still lets sandboxed commands create or modify protected metadata paths.
Useful? React with 👍 / 👎.
| #[allow(dead_code)] | ||
| #[serde(default)] | ||
| protected_metadata_targets: Vec<ProtectedMetadataTarget>, |
There was a problem hiding this comment.
Apply protected metadata targets in the setup helper
The helper now deserializes protected_metadata_targets, but the field is marked dead code and is never read; setup only applies ACLs from deny_write_paths. Even after callers pass targets, ExistingDeny/MissingCreationMonitor modes have no effect in elevated setup, leaving protected metadata writable/creatable.
Useful? React with 👍 / 👎.
Summary
Why
Stack Relation
This PR is part 5 of 21 in the Windows protected metadata stack.
Validation
95ef124d6194bd2126c11928cb3973214f9ac63a.95ef124d6194bd2126c11928cb3973214f9ac63a.