Pass Windows metadata targets to direct exec#21032
Conversation
d4a25ea to
f29e31e
Compare
72abfca to
16cc0e9
Compare
f29e31e to
230dcf4
Compare
16cc0e9 to
461f186
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 461f186a34
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mut env_map: HashMap<String, String>, | ||
| timeout_ms: Option<u64>, | ||
| additional_deny_write_paths: &[PathBuf], | ||
| _protected_metadata_targets: &[ProtectedMetadataTarget], |
There was a problem hiding this comment.
Enforce metadata targets in legacy direct exec
The new direct-exec plumbing passes protected_metadata_targets to the non-elevated backend, but this callee names it _protected_metadata_targets and never applies prepare_protected_metadata_targets/deny paths or cleanup. When use_elevated is false, protected metadata remains writable/creatable despite the commit's stated enforcement goal.
Useful? React with 👍 / 👎.
Summary
Why
Stack Relation
This PR is part 6 of 21 in the Windows protected metadata stack.
Validation
95ef124d6194bd2126c11928cb3973214f9ac63a.95ef124d6194bd2126c11928cb3973214f9ac63a.