Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0ed87b84a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced May 18, 2026
This was referenced May 20, 2026
iceweasel-oai
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows sandbox migration away from the legacy
SandboxPolicyabstraction needs a small local bridge before IPC and core wiring can move toPermissionProfile. Leaf helpers currently branch directly onWorkspaceWrite, which spreads legacy assumptions through path planning and token setup code.This PR introduces a Windows-local resolved permissions view so those helpers can ask Windows-specific questions about runtime filesystem/network permissions without matching on the legacy policy enum everywhere.
What changed
ResolvedWindowsSandboxPermissionsinwindows-sandbox-rs/src/resolved_permissions.rs, with legacySandboxPolicyconstructors for the current call sites.allow.rswritable-root and read-only-subpath planning onto the resolved permissions type.TEMP/TMPwritable-root behavior when the effective policy includes writable tmpdir access.:slash_tmpor parent-processTMPDIRwhile computing Windows writable roots.Verification
cargo test -p codex-windows-sandboxjust fix -p codex-windows-sandboxStack created with Sapling. Best reviewed with ReviewStack.