Skip to content

Fix Windows doctor npm root probe#22967

Merged
etraut-openai merged 2 commits into
mainfrom
etraut/doctor-windows-npm-cmd
May 16, 2026
Merged

Fix Windows doctor npm root probe#22967
etraut-openai merged 2 commits into
mainfrom
etraut/doctor-windows-npm-cmd

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

Why

On Windows npm-managed installs expose the working shim as npm.cmd. codex doctor probed bare npm, which could incorrectly report that npm global-root inspection was unavailable even when the install was healthy.

Fixes #22964.

What changed

  • Use npm.cmd for the doctor npm-root probe on Windows.
  • Keep the existing npm probe on non-Windows platforms.

@etraut-openai etraut-openai changed the title [codex] Fix Windows doctor npm root probe Fix Windows doctor npm root probe May 16, 2026
@etraut-openai etraut-openai merged commit de9c5c0 into main May 16, 2026
31 checks passed
@etraut-openai etraut-openai deleted the etraut/doctor-windows-npm-cmd branch May 16, 2026 07:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows: codex doctor cannot inspect npm global root because it spawns npm instead of npm.cmd

2 participants