Skip to content

Fix Windows doctor npm root probe #22967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etraut-openai merged 2 commits into from
May 16, 2026
+5 −1
Merged

Fix Windows doctor npm root probe #22967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc69ced
doctor: use npm.cmd for Windows npm root probe (#22964)
etraut-openai May 16, 2026
55f6ceb
Merge branch 'main' into etraut/doctor-windows-npm-cmd
etraut-openai May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion codex-rs/cli/src/doctor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ const COLOR_ENV_VARS: &[&str] = &[
const TERMINAL_DIMENSION_ENV_VARS: &[&str] = &["COLUMNS", "LINES"];
const TERMINFO_ENV_VARS: &[&str] = &["TERMINFO", "TERMINFO_DIRS"];
const LOCALE_ENV_VARS: &[&str] = &["LC_ALL", "LC_CTYPE", "LANG"];
#[cfg(windows)]
const NPM_COMMAND: &str = "npm.cmd";
#[cfg(not(windows))]
const NPM_COMMAND: &str = "npm";
const REMOTE_TERMINAL_ENV_VARS: &[&str] = &[
"SSH_TTY",
"SSH_CONNECTION",
Expand Down Expand Up @@ -884,7 +888,7 @@ fn npm_global_root_check() -> NpmRootCheck {
return NpmRootCheck::MissingPackageRoot;
};

let output = match run_command("npm", ["root", "-g"]) {
let output = match run_command(NPM_COMMAND, ["root", "-g"]) {
Ok(output) => output,
Err(err) => return NpmRootCheck::NpmUnavailable(err),
};
Expand Down
Loading