Clarify resume hints for renamed threads#23234
Merged
Merged
Conversation
This was referenced May 18, 2026
## Why PR #23234 updates the resume messaging for renamed threads to tell users to pick `<name> (<thread-id>)` from the resume picker, but the expanded picker details still hid the session id once a thread had a name. That left a mismatch between the new guidance text and the picker UI. When duplicate thread names exist, the expanded `Session:` field should continue to expose the id so the user can verify they are about to resume the right session. ## What Changed - show `<thread-name> (<thread-id>)` in the resume picker `Session:` field when both values are available - keep the existing fallback behavior for unnamed sessions or rows without an id - update the existing picker rendering test to cover the combined session label ## How to Test 1. Check out this branch on top of `etraut/clarify-resume-hints`. 2. Start Codex, create or resume a session, and rename it. 3. Open `codex resume` and expand the renamed session entry. 4. Confirm the `Session:` field shows `<thread-name> (<thread-id>)` instead of hiding the id. Also verify that: 1. A session without a thread name still shows just the thread id in the `Session:` field. 2. The main row title in the picker is unchanged; this PR only updates the expanded details view. Targeted tests: - `cargo test -p codex-tui expanded_session_details_include_metadata` Note: `cargo test -p codex-tui` still fails in this worktree because of an unrelated existing stack overflow in `app::tests::discard_side_thread_removes_agent_navigation_entry`.
fcoury-oai
approved these changes
May 18, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Works as expected, code looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #23181
Why
Renamed threads can share names, so hints that suggest resuming directly by name are ambiguous. Issue #23181 asks for the picker hint to include the thread name and thread ID in parens so users can disambiguate safely.
What
codex resume, then select<name> (<thread-id>).codex resume <thread-id>guidance for unnamed threads.Verification
Manually verified that message after
/renameand after/exitinclude session ID in parens.