Show session ids in resume picker details#23334
Merged
fcoury-oai merged 1 commit intoMay 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #23234 updates the resume messaging for renamed threads to tell users to pick
<name> (<thread-id>)from the resume picker, but the expanded picker details still hid the session id once a thread had a name.That left a mismatch between the new guidance text and the picker UI. When duplicate thread names exist, the expanded
Session:field should continue to expose the id so the user can verify they are about to resume the right session.What Changed
<thread-name> (<thread-id>)in the resume pickerSession:field when both values are availableHow to Test
etraut/clarify-resume-hints.codex resumeand expand the renamed session entry.Session:field shows<thread-name> (<thread-id>)instead of hiding the id.Also verify that:
Session:field.Targeted tests:
cargo test -p codex-tui expanded_session_details_include_metadataNote:
cargo test -p codex-tuistill fails in this worktree because of an unrelated existing stack overflow inapp::tests::discard_side_thread_removes_agent_navigation_entry.