Skip to content

[codex] Steer budget-limited goal extension turns#23718

Merged
jif-oai merged 4 commits into
mainfrom
codex/steer-budget-limited-goal-extension
May 21, 2026
Merged

[codex] Steer budget-limited goal extension turns#23718
jif-oai merged 4 commits into
mainfrom
codex/steer-budget-limited-goal-extension

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 20, 2026

What

  • Add a small extension capability for injecting model-visible response items into the active turn
  • Have the goal extension inject hidden goal-context steering when tool-finish accounting reaches BudgetLimited
  • Cover the extension backend path with an assertion on the injected steering item

Why

PR #23696 persists and emits the budget-limited goal update from tool-finish accounting, but it leaves the model unaware of that transition. The existing core runtime steers the model to wrap up in this case; the extension path should do the same through an explicit host capability.

Testing

  • just fmt
  • cargo test -p codex-goal-extension
  • cargo test -p codex-extension-api

@jif-oai jif-oai marked this pull request as ready for review May 20, 2026 16:50
@jif-oai jif-oai requested a review from a team as a code owner May 20, 2026 16:50
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 20, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2646e4c50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/ext/goal/src/extension.rs
Comment thread codex-rs/ext/goal/src/steering.rs Outdated
Comment thread codex-rs/ext/goal/src/steering.rs
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented May 20, 2026

@codex review

…mited-goal-extension

# Conflicts:
#	codex-rs/ext/goal/src/extension.rs
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6cd6e18f86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/ext/goal/Cargo.toml
Comment thread codex-rs/ext/goal/src/steering.rs
@jif-oai jif-oai merged commit 791b69d into main May 21, 2026
31 checks passed
@jif-oai jif-oai deleted the codex/steer-budget-limited-goal-extension branch May 21, 2026 10:54
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant