release: package prebuilt resource binaries

[bolinfest]

Why

Release packaging should be a staging step once release binaries have already been built and signed. The Windows release job was downloading and signing codex-command-runner.exe and codex-windows-sandbox-setup.exe, but scripts/build_codex_package.py still rebuilt those helpers while creating the package archives.

That makes the package step slower and, more importantly, risks putting helper binaries in the archive that were produced after the signing step. Linux had the same shape for package resources: bwrap could be rebuilt by the package builder instead of being passed in as a prebuilt release artifact.

This builds on #23752, which fixes .tar.zst creation when Windows runners rely on the repository DotSlash zstd wrapper.

What changed

• Add explicit prebuilt resource inputs to the Codex package builder:
  • --bwrap-bin
  • --codex-command-runner-bin
  • --codex-windows-sandbox-setup-bin
• Make .github/scripts/build-codex-package-archive.sh pass resource binaries from the release output directory when they are already present.
• Build Linux bwrap for app-server release jobs too, so app-server package creation does not invoke Cargo just to supply the package resource.
• Keep macOS package creation as a no-Cargo path when --entrypoint-bin is provided, since macOS packages have no resource binaries.
• Add unit coverage showing prebuilt macOS, Linux, and Windows package inputs result in no source-built binaries.

Verification

• python3 -m unittest discover -s scripts/codex_package -p 'test_*.py'
• python3 -m py_compile scripts/codex_package/*.py
• bash -n .github/scripts/build-codex-package-archive.sh
• Dry-ran Linux and Windows package builds with fake prebuilt resources and a nonexistent Cargo path to verify the package builder did not invoke Cargo.

---

Stack created with Sapling. Best reviewed with ReviewStack.

• ci: run Codex package builder tests #23760
• -> release: package prebuilt resource binaries #23759

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bdafb7ab46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Guard empty resource arg expansion under nounset

When this script is invoked for macOS packaging paths (for example .github/workflows/rust-release.yml Build Codex package archive steps around lines 522-535 and 836-848), no resource flags are provided, so resource_args stays empty. Under set -u, Bash 3.2 (the default shell on GitHub macOS runners) treats "${resource_args[@]}" as an unbound expansion for an empty array, causing the packaging command to abort before build_codex_package.py runs. Please gate this expansion (e.g., only append the array when non-empty) so macOS release packaging does not fail.

Useful? React with 👍 / 👎.