tui: keep inaccessible apps out of mentions#24625
Merged
Merged
Conversation
8080a02 to
870d93f
Compare
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 870d93f248
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
approved these changes
May 26, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Smoke tested with $app and the difference is obvious. Code looks very straightforward.
Approved 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the TUI
$app mention paths so App Directory rows that are not accessible are not treated as usable apps.This includes the core preservation fix from #24104, but expands it to the other app mention paths:
is_accessibleflags when partialapp/list/updatedsnapshots reach the TUI$slugmentionsapp://...bindings to point at accessible, enabled apps before emitting structured app mentionscodex-chatgptdependency fromcodex-tui, which addresses thecargo shearfailure seen on tui: keep inaccessible apps out of the mention picker #24104Root Cause
The app server already sends merged app snapshots with accessibility computed. The TUI handled app-server app list updates as partial app loads and re-ran the old accessible-app merge path. That path treated every notification row as accessible, so App Directory entries with
isAccessible=falsecould appear in$suggestions.Regression source: #22914 routed app-list updates through the app server while reusing the old TUI partial-load handling. Related precursor: #14717 introduced the partial-load path, but #22914 made it user-visible for app-server updates.
Issues
Fixes #24145
Fixes #24205
Fixes #24319
Validation
just fmtgit diff --checkjust bazel-lock-updatejust bazel-lock-checkjust argument-comment-lint -p codex-tuijust test -p codex-tui chatwidget::tests::popups_and_settings::apps_notification_update_excludes_inaccessible_apps_from_mentions chatwidget::tests::composer_submission::submit_user_message_ignores_inaccessible_app_mentions_from_bindings chatwidget::skills::tests::find_app_mentions_requires_accessible_enabled_apps_for_bound_paths chatwidget::skills::tests::find_app_mentions_requires_accessible_enabled_apps_for_slugs