Skip to content

Show activity for standalone web search calls#24693

Merged
sayan-oai merged 4 commits into
mainfrom
sayan/standalone-web-search-activity
May 29, 2026
Merged

Show activity for standalone web search calls#24693
sayan-oai merged 4 commits into
mainfrom
sayan/standalone-web-search-activity

Conversation

@sayan-oai
Copy link
Copy Markdown
Collaborator

@sayan-oai sayan-oai commented May 27, 2026

Why

Standalone web.run calls run in the extension, so they need normal web-search progress activity while a request is in flight and durable completed activity after a thread is reloaded.

Follow-up to #23823; uses the extension turn-item emission path added in #24813.

What changed

  • Emit standalone web.run start/completion items through the host turn-item emitter, preserving standard client delivery and rollout persistence.
  • Include useful completion detail for queries, image queries, and literal-URL open/find commands.
  • Render completed searches as Searched the web or Searched the web for <detail>, with snapshot coverage for the detail-free case.
  • Extend the app-server round-trip test to verify completed search activity is reconstructed by thread/read after a fresh-process reload.

Testing

  • just test -p codex-web-search-extension
  • just test -p codex-app-server -E "test(standalone_web_search_round_trips_encrypted_output)"

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8b642836c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/ext/web-search/src/events.rs Outdated
Comment thread codex-rs/app-server/src/extensions.rs Outdated
@sayan-oai
Copy link
Copy Markdown
Collaborator Author

@codex review this

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bab1e7d324

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/ext/web-search/src/tool.rs
Comment thread codex-rs/ext/web-search/src/tool.rs Outdated
@sayan-oai sayan-oai force-pushed the sayan/standalone-web-search-activity branch from e0ef3b6 to ad2852d Compare May 29, 2026 16:01
@sayan-oai sayan-oai enabled auto-merge (squash) May 29, 2026 16:12
@sayan-oai sayan-oai merged commit 96f1347 into main May 29, 2026
31 checks passed
@sayan-oai sayan-oai deleted the sayan/standalone-web-search-activity branch May 29, 2026 16:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants