feat(exec-server): canonicalize executor paths [1 of 6]#25337
feat(exec-server): canonicalize executor paths [1 of 6]#25337fcoury-oai wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0db653e858
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0db653e to
d9e6828
Compare
|
Linking related Windows Desktop + WSL context from #25317 / #25370 because this PR touches executor path canonicalization. This canonicalization work may be useful for workspace mutations, but it should not be treated as fixing the current WSL shell/tool regression. In #25317, the workspace path exists and canonicalization is not the failing boundary. The broken state is a stale The deeper issue is cross-runtime helper ownership: Windows-native Codex/plugin paths and the WSL app-server can share the same |
d8db042 to
f88a129
Compare
f88a129 to
19473da
Compare
Why
Workspace mutations must canonicalize paths through the selected execution environment. Resolving a remote path on the app-server host would validate the wrong filesystem and could persist an invalid access boundary.
What Changed
canonicalize(path)to the executor filesystem abstraction.fs/canonicalizeexec-server RPC and route it through local, sandboxed, and remote filesystem implementations.How to Test
fs/canonicalizeover RPC instead of resolving the path on the host.Targeted tests:
direct_file_system_canonicalizes_symlinksfs_canonicalize_uses_remote_rpcStack