feat(core): enforce workspace mutation ordering [2 of 5]#25339
Open
fcoury-oai wants to merge 3 commits into
Open
feat(core): enforce workspace mutation ordering [2 of 5]#25339fcoury-oai wants to merge 3 commits into
fcoury-oai wants to merge 3 commits into
Conversation
This was referenced May 30, 2026
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7dd521da4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
eb798f8 to
7095747
Compare
655d3d8 to
7061d0a
Compare
8f426d8 to
b519ecb
Compare
3298e20 to
ff7f72c
Compare
b519ecb to
e726188
Compare
ff7f72c to
4752cc0
Compare
bd74c54 to
06c6dc4
Compare
4752cc0 to
b20432c
Compare
06c6dc4 to
a54c1c6
Compare
2de1f60 to
904629e
Compare
a54c1c6 to
dff59a0
Compare
904629e to
cd09970
Compare
dff59a0 to
8ccab0f
Compare
cd09970 to
f5ecd1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A directory mutation cannot execute like an ordinary parallel tool call. Calls after it must observe the updated cwd and permission context, and they must not run against stale state if the mutation fails.
What Changed
ToolExecutionPolicywith parallel and barrier-and-cancel-suffix modes.dependency_cancelledoutputs for calls skipped behind a failed mutation barrier.How to Test
dependency_cancelledoutputs.Targeted tests:
failed_barrier_cancels_suffix_without_dispatching_itcore/src/tools/parallel.rsStack