Skip to content

[profile-switcher][rust] -- [1/2] Add app-server account session protocol#25469

Merged
dhruvgupta-oai merged 3 commits into
mainfrom
dev/dhruvgupta/desktop-account-sessions-rust-protocol
Jun 3, 2026
Merged

[profile-switcher][rust] -- [1/2] Add app-server account session protocol#25469
dhruvgupta-oai merged 3 commits into
mainfrom
dev/dhruvgupta/desktop-account-sessions-rust-protocol

Conversation

@dhruvgupta-oai
Copy link
Copy Markdown
Contributor

@dhruvgupta-oai dhruvgupta-oai commented Jun 1, 2026

Summary

Adds the app-server v2 accountSession/* protocol used by the Desktop profile switcher and the backend account metadata client needed to populate workspace choices.

This is the protocol layer only. The app-server lifecycle and consolidated saved-session storage are split into a follow-up PR.

Rust Stack

  1. This PR
  2. openai/codex#25383 adds app-server session lifecycle behavior and consolidated saved-session storage.

Validation

  • Generated app-server schema fixtures are included from the existing generation flow in the lifecycle PR where the routes are registered.
  • Did not run tests per requested scope.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b7bce9beb7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server-protocol/src/protocol/common.rs Outdated
Comment thread codex-rs/backend-client/src/types.rs
@dhruvgupta-oai dhruvgupta-oai changed the title [profile-switcher][rust] -- [1/3] Add app-server account session protocol [profile-switcher][rust] -- [1/2] Add app-server account session protocol Jun 2, 2026
@dhruvgupta-oai dhruvgupta-oai force-pushed the dev/dhruvgupta/desktop-account-sessions-rust-protocol branch from 8cf9a3d to 3ad4592 Compare June 2, 2026 09:26
#[serde(rename_all = "camelCase")]
#[ts(export_to = "v2/")]
pub enum AccountSessionWorkspaceKind {
Personal,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't personal users have workspaces too?

Copy link
Copy Markdown
Contributor Author

@dhruvgupta-oai dhruvgupta-oai Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal is its own type of workspace. So like personal workspace or business workspace. A users can have multiple workspaces but each workspace only has one type.

@dhruvgupta-oai dhruvgupta-oai merged commit a2ebe07 into main Jun 3, 2026
31 checks passed
@dhruvgupta-oai dhruvgupta-oai deleted the dev/dhruvgupta/desktop-account-sessions-rust-protocol branch June 3, 2026 19:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants