[profile-switcher][rust] -- [2/3] Add saved account session credential slots#25470
Closed
dhruvgupta-oai wants to merge 4 commits into
Conversation
This was referenced Jun 1, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7086019fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dhruvgupta-oai
force-pushed
the
dev/dhruvgupta/desktop-account-sessions-rust-storage
branch
from
e708601 to
c4c1505
Compare
dhruvgupta-oai
force-pushed
the
dev/dhruvgupta/desktop-account-sessions-rust-storage
branch
3 times, most recently
from
6e0d3d5 to
cffab69
Compare
dhruvgupta-oai
force-pushed
the
dev/dhruvgupta/desktop-account-sessions-rust-storage
branch
from
cffab69 to
fd36ea0
Compare
Contributor
Author
|
Superseded by the consolidated one-file account session store in #25383. Saved session credentials now live inside account-sessions.json, so the intermediate credential-slot layer is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the existing
codex-loginstorage abstraction with per-session credential slots. Saved Desktop account sessions now use the configured file, keyring, auto, or ephemeral backend without replacing the active auth payload.This keeps saved-session OAuth credentials out of app-server metadata and preserves keyring-backed storage when keyring mode is configured.
Rust Stack
Validation
just fmt; the Rust formatter completed before the repo-wide Pythonruffphase hit a sandbox cache restriction.