Skip to content

Fix Windows release PDB staging#25916

Merged
shijie-oai merged 1 commit into
mainfrom
dev/shijie/fix-windows-pdb-staging
Jun 2, 2026
Merged

Fix Windows release PDB staging#25916
shijie-oai merged 1 commit into
mainfrom
dev/shijie/fix-windows-pdb-staging

Conversation

@shijie-oai
Copy link
Copy Markdown
Collaborator

Summary

  • Teach the Windows release prebuild staging step to locate Rust/MSVC PDBs emitted with crate-style underscore names.
  • Stage PDBs under the shipped hyphenated binary names so the downstream symbol archive step keeps the same artifact contract.
  • Keep a fallback for already-hyphenated PDB names and fail with a clear diagnostic if neither form exists.

Root cause

The recent symbol publishing change in #25649 started copying ${binary}.pdb from target/<triple>/release during Windows prebuild staging. Cargo still emits the .exe with the hyphenated binary name, but MSVC PDBs for hyphenated Rust crates are emitted with underscores, for example codex_app_server.pdb for codex-app-server.exe. The release workflow was still building into the expected directory; the new PDB copy step was looking for the wrong filename.

Impact

This unblocks the rust-release Windows prebuilt-binary jobs for hyphenated binaries while preserving the hyphenated PDB names consumed by the final Windows release packaging and symbol archive steps.

Validation

  • just fmt from codex-rs
  • git diff --check -- .github/workflows/rust-release-windows.yml
  • Parsed .github/workflows/rust-release-windows.yml as YAML locally
  • Local bash staging sanity test for both underscore-emitted and hyphenated PDB filenames

@shijie-oai shijie-oai marked this pull request as ready for review June 2, 2026 19:00
@shijie-oai shijie-oai merged commit de124c3 into main Jun 2, 2026
31 checks passed
@shijie-oai shijie-oai deleted the dev/shijie/fix-windows-pdb-staging branch June 2, 2026 19:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants