Fix Windows release PDB staging#25916
Merged
Merged
Conversation
anp-oai
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The recent symbol publishing change in #25649 started copying
${binary}.pdbfromtarget/<triple>/releaseduring Windows prebuild staging. Cargo still emits the.exewith the hyphenated binary name, but MSVC PDBs for hyphenated Rust crates are emitted with underscores, for examplecodex_app_server.pdbforcodex-app-server.exe. The release workflow was still building into the expected directory; the new PDB copy step was looking for the wrong filename.Impact
This unblocks the
rust-releaseWindows prebuilt-binary jobs for hyphenated binaries while preserving the hyphenated PDB names consumed by the final Windows release packaging and symbol archive steps.Validation
just fmtfromcodex-rsgit diff --check -- .github/workflows/rust-release-windows.yml.github/workflows/rust-release-windows.ymlas YAML locally