Speed up review branch picker via for-each-ref#31464
Merged
Merged
Conversation
charliemarsh-oai
force-pushed
the
charlie/faster-review-branch-picker
branch
from
d474f34 to
170554a
Compare
charliemarsh-oai
changed the title
for-each-ref
charliemarsh-oai
commented
Jul 7, 2026
| local_git_branches(repo).await, | ||
| vec!["main".to_string(), "feature/local".to_string()] | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Incidentally, on main, if you're in a detached HEAD, we show (detached HEAD) -> (HEAD detached at abc123). That's now omitted.
anp-oai
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening
/reviewand choosing a branch currently enumerates branches throughgit branch, which performs broader branch presentation work. In a large repo, it isn't hard for this to timeout completely.This PR instead uses
git for-each-refscoped directly torefs/headsso the picker reads only local branch refs. It preserves the existing sorting and default-branch promotion while excluding remote-tracking refs and detached-HEAD display rows.