Skip to content

Log plugin install failure subtypes#31518

Merged
charlesgong-openai merged 2 commits into
mainfrom
dev/charlesgong/import-failure-sub-error-types
Jul 8, 2026
Merged

Log plugin install failure subtypes#31518
charlesgong-openai merged 2 commits into
mainfrom
dev/charlesgong/import-failure-sub-error-types

Conversation

@charlesgong-openai

@charlesgong-openai charlesgong-openai commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • classify plugin store and remote bundle I/O failures by privacy-safe operation context
  • include the normalized sub_error_type in structured plugin-install failure warnings
  • leave analytics events and schemas unchanged

Why

Top-level error types such as store_io collapse multiple filesystem operations, making logs harder to diagnose. The subtype identifies the failed operation without logging paths or new exception details.

Impact

Plugin-install warning logs gain an optional normalized subtype. Analytics payloads, app-server APIs, and stored data are unchanged.

Validation

  • just fmt
  • just test -p codex-core-plugins -p codex-app-server (1,235 passed; 14 failed and 6 timed out because local sandbox-exec was denied, test_stdio_server was unavailable, or user-level skill fixtures were loaded)

@charlesgong-openai charlesgong-openai force-pushed the dev/charlesgong/import-failure-sub-error-types branch from ee7eb97 to df65c4a Compare July 8, 2026 03:31
@charlesgong-openai charlesgong-openai changed the title Add import failure sub-error telemetry Log plugin install failure subtypes Jul 8, 2026
@charlesgong-openai charlesgong-openai changed the base branch from dev/charlesgong/session-import-and-command-migration to main July 8, 2026 03:31
@charlesgong-openai charlesgong-openai marked this pull request as ready for review July 8, 2026 14:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df65c4a1f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core-plugins/src/manager.rs Outdated
Comment thread codex-rs/app-server/src/request_processors/plugins.rs Outdated
@charlesgong-openai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 8436306dde

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@charlesgong-openai charlesgong-openai merged commit 1ee0e9a into main Jul 8, 2026
35 checks passed
@charlesgong-openai charlesgong-openai deleted the dev/charlesgong/import-failure-sub-error-types branch July 8, 2026 15:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants