feat(core): emit canonical hook prompt items#31630
Merged
Merged
Conversation
owenlin0
force-pushed
the
owen/ca-676-canonical-hook-prompts
branch
from
334cb41 to
0584975
Compare
owenlin0
force-pushed
the
owen/ca-676-canonical-hook-prompts
branch
from
0584975 to
6f98e76
Compare
pakrym-oai
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves hook prompts onto the canonical
TurnItemlifecycle in core.Stop hooks now record their
ResponseItemthrough the existing lifecycle path, which emitsItemStartedandItemCompleted. App-server consumes those events directly instead of deriving a hook prompt fromRawResponseItem.Why
Hook prompts were the only
ThreadItemapp-server synthesized fromRawResponseItem. This brings them in line with other core-owned turn items while preserving legacy rollout replay.What changed
record_response_item_and_emit_turn_item.ThreadHistoryBuilder.RawResponseItemtoThreadItemsynthesis while preserving legacy rollout replay.