exec-server: materialize filesystem workspace roots#31892
Merged
Conversation
pakrym-oai
force-pushed
the
pakrym/full-ci-fs-workspace-roots
branch
from
aa1b8e8 to
1915f31
Compare
pakrym-oai
changed the base branch from
pakrym/full-ci-environment-workspace-roots
to
main
viyatb-oai
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filesystem helper requests currently turn symbolic
:workspace_rootspermissions into a sandbox policy before applying the workspace roots from the filesystem sandbox context. This can accidentally broaden filesystem access to the cwd instead of limiting it to the selected workspace roots.Materialize project-root permissions using the context workspace roots before deriving the filesystem sandbox policy. The same converted roots are then reused when constructing the sandbox command, keeping policy enforcement and process setup aligned.
Adds a remote filesystem integration test that verifies a file inside the selected workspace root is readable while a sibling under the cwd is denied.
Validation
just test -p codex-exec-server remote_read_file_materializes_environment_workspace_roots(macOS, outside the outer Seatbelt sandbox)