Honor personality = "none" in model instructions#32277
Merged
copyberry[bot] merged 1 commit intoJul 10, 2026
Merged
Conversation
## Why Model catalog instructions can include a baked-in `# Personality` section. An explicit `none` setting should omit that section instead of sending it as part of the model's base instructions. ## What changed - Pass the configured personality into the models manager. - When personality support is enabled and the setting is explicitly `none`, remove the `# Personality` section through the next level-one heading from catalog base instructions and instruction templates. - Preserve explicit `base_instructions` overrides and avoid warning when no personality was requested. ## Testing Added unit and integration coverage for section removal, heading boundaries, CRLF input, preserved configurations, and explicit base instructions. GitOrigin-RevId: 452c88d3ac6001c2ac7d4fef269cd75dc239fa61
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/452c88d3ac6001c2ac7d4fef269cd75dc239fa61
branch
from
d665750 to
09ccae2
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/452c88d3ac6001c2ac7d4fef269cd75dc239fa61
branch
avinashresearch1
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
avinashresearch1
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
avinashresearch1
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honor
personality = "none"in model instructionsWhy
Model catalog instructions can include a baked-in
# Personalitysection. Anexplicit
nonesetting should omit that section instead of sending it as partof the model's base instructions.
What changed
none,remove the
# Personalitysection through the next level-one heading fromcatalog base instructions and instruction templates.
base_instructionsoverrides and avoid warning when nopersonality was requested.
Testing
Added unit and integration coverage for section removal, heading boundaries,
CRLF input, preserved configurations, and explicit base instructions.