Skip to content

Include terminal errors in turn completion events#32280

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8d32942a44132763076130102d8b89ab356d59d0
Jul 10, 2026
Merged

Include terminal errors in turn completion events#32280
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/8d32942a44132763076130102d8b89ab356d59d0

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Include terminal errors in turn completion events

What changed

  • Add an optional error payload to TurnCompleteEvent and omit it when a turn completes without an error.
  • Preserve the full terminal ErrorEvent through the turn lifecycle so the completion event includes the same error details emitted separately by EventMsg::Error.

Testing

  • Extend the stream-error integration test to verify that TurnCompleteEvent contains the emitted error and that the next turn can still proceed.

@owenlin0
Include terminal errors in turn completion events (#32280)
c4318c3 
## What changed

- Add an optional `error` payload to `TurnCompleteEvent` and omit it when a turn completes without an error.
- Preserve the full terminal `ErrorEvent` through the turn lifecycle so the completion event includes the same error details emitted separately by `EventMsg::Error`.

## Testing

- Extend the stream-error integration test to verify that `TurnCompleteEvent` contains the emitted error and that the next turn can still proceed.

GitOrigin-RevId: 8d32942a44132763076130102d8b89ab356d59d0
@copyberry copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/8d32942a44132763076130102d8b89ab356d59d0 branch from f17cb12 to c4318c3 Compare July 10, 2026 22:05
@copyberry copyberry Bot merged commit c4318c3 into main Jul 10, 2026
14 of 32 checks passed
@copyberry copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/8d32942a44132763076130102d8b89ab356d59d0 branch July 10, 2026 22:06
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mariusvniekerk @johnsilvavlogs @ernz300 @budhasantosh010 @Statusnone420 @owenlin0