Skip to content

Trust hooks from materialized workspace plugins#32301

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0b150766415be6fccc117f7856a241e10ad456f2
Jul 11, 2026
Merged

Trust hooks from materialized workspace plugins#32301
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0b150766415be6fccc117f7856a241e10ad456f2

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 11, 2026

Copy link
Copy Markdown

Trust hooks from materialized workspace plugins

What changed

  • Carry newly installed or updated remote plugin metadata through effective-plugin refresh callbacks, including coalesced refreshes.
  • After a successful refresh, record the current hook hashes for listed workspace plugins associated with the active account while preserving existing hook settings and unrelated state.
  • Serialize the background trust write with config mutations, and leave hooks untrusted if the write fails or the active account changes.

Testing

  • Cover eligible plugin selection and escaped hook config keys.
  • Verify end-to-end trust for newly materialized plugin hooks, preservation of existing config, and fail-closed behavior when config cannot be written.

## What changed

- Carry newly installed or updated remote plugin metadata through effective-plugin refresh callbacks, including coalesced refreshes.
- After a successful refresh, record the current hook hashes for listed workspace plugins associated with the active account while preserving existing hook settings and unrelated state.
- Serialize the background trust write with config mutations, and leave hooks untrusted if the write fails or the active account changes.

## Testing

- Cover eligible plugin selection and escaped hook config keys.
- Verify end-to-end trust for newly materialized plugin hooks, preservation of existing config, and fail-closed behavior when config cannot be written.

GitOrigin-RevId: 0b150766415be6fccc117f7856a241e10ad456f2
@copyberry copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/0b150766415be6fccc117f7856a241e10ad456f2 branch from 30dd155 to 076a110 Compare July 11, 2026 01:12
@copyberry copyberry Bot merged commit 076a110 into main Jul 11, 2026
14 of 32 checks passed
@copyberry copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/0b150766415be6fccc117f7856a241e10ad456f2 branch July 11, 2026 01:13
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant