Improve composer completion target resolution#32628
Merged
copyberry[bot] merged 1 commit intoJul 12, 2026
Merged
Conversation
## What changed - Resolve `@` and `$` completion targets on either side of the cursor while treating atomic text elements and line breaks as boundaries. - Prefer the nearest editable mention when file, skill, and plugin candidates compete, and avoid treating common uppercase environment variables as skill queries. - Insert a separator before completions adjacent to atomic elements and keep dismissed popup state scoped to the matching editable token occurrence. ## Testing - Add unit and snapshot coverage for adjacent and partially bound mentions, whitespace boundaries, shell variables, popup dismissal, and file, image, skill, and plugin insertion. GitOrigin-RevId: 352a42c7bcdbf4f6cd35368ced25f71926fdbc1b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/352a42c7bcdbf4f6cd35368ced25f71926fdbc1b
branch
from
c7da1cd to
c888e8e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/352a42c7bcdbf4f6cd35368ced25f71926fdbc1b
branch
flydragon2018
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
flydragon2018
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
flydragon2018
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
bjoern-vollan
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
bjoern-vollan
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
bjoern-vollan
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
AlgebraLoveme
temporarily deployed
to
issue-triage
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve composer completion target resolution
What changed
@and$completion targets on either side of the cursor while treating atomic text elements and line breaks as boundaries.Testing