Skip to content

Align installed app duration metrics with the legacy baseline#35015

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0755dcaaa94f1d973adfc62a27ea97e3e01edc8b
Jul 23, 2026
Merged

Align installed app duration metrics with the legacy baseline#35015
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0755dcaaa94f1d973adfc62a27ea97e3e01edc8b

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 23, 2026

Copy link
Copy Markdown

Align installed app duration metrics with the legacy baseline

Why

The snapshot-backed apps/installed duration metric needs dimensions that can
be compared with the legacy app/list baseline.

What changed

  • Label snapshot-backed duration samples with path=installed and add the
    legacy-compatible reload dimension alongside the detailed refresh fields.
  • Record duration samples only for successful responses so failed requests do
    not enter the success latency distribution.

Testing

Added unit coverage for the duration metric dimensions on refreshed and
non-refreshed requests, and for omitting samples on failed requests.

## Why

The snapshot-backed `apps/installed` duration metric needs dimensions that can
be compared with the legacy `app/list` baseline.

## What changed

- Label snapshot-backed duration samples with `path=installed` and add the
  legacy-compatible `reload` dimension alongside the detailed refresh fields.
- Record duration samples only for successful responses so failed requests do
  not enter the success latency distribution.

## Testing

Added unit coverage for the duration metric dimensions on refreshed and
non-refreshed requests, and for omitting samples on failed requests.

GitOrigin-RevId: 0755dcaaa94f1d973adfc62a27ea97e3e01edc8b
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/0755dcaaa94f1d973adfc62a27ea97e3e01edc8b branch from 6378989 to ceb2ffb Compare July 23, 2026 21:31
@copyberry
copyberry Bot merged commit ceb2ffb into main Jul 23, 2026
19 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/0755dcaaa94f1d973adfc62a27ea97e3e01edc8b branch July 23, 2026 21:32
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant