Use the shared HTTP client for TUI network checks - #35821
Merged
copyberry[bot] merged 1 commit intoJul 28, 2026
Merged
Conversation
## Why TUI update checks and local OSS provider detection constructed their own HTTP clients instead of using Codex's shared client behavior. ## What changed - Route update requests through the configured route-aware client pool while retaining the existing default headers and custom CA fallback. - Probe the hardcoded LM Studio and Ollama loopback endpoints with a shared direct client and a per-request timeout. - Limit the legacy invalid-custom-CA fallback to the default routing policy so system-proxy routing still reports certificate configuration errors. ## Testing Add coverage for local provider probes with invalid `CODEX_CA_CERTIFICATE` and `SSL_CERT_FILE` values, and for custom CA fallback under both routing policies. GitOrigin-RevId: b5c230b61e8964b3f1af3395052361ff716d6ce1
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b5c230b61e8964b3f1af3395052361ff716d6ce1
branch
from
July 28, 2026 19:59
886d7ce to
8bbdf6c
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b5c230b61e8964b3f1af3395052361ff716d6ce1
branch
July 28, 2026 20:00
ignaciomontenegroc
temporarily deployed
to
issue-triage
July 28, 2026 20:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
ignaciomontenegroc
temporarily deployed
to
issue-triage
July 28, 2026 20:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ignaciomontenegroc
temporarily deployed
to
issue-triage
July 28, 2026 20:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ignaciomontenegroc
temporarily deployed
to
issue-triage
July 28, 2026 20:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ignaciomontenegroc
temporarily deployed
to
issue-triage
July 28, 2026 20:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ignaciomontenegroc
temporarily deployed
to
issue-triage
July 28, 2026 20:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the shared HTTP client for TUI network checks
Why
TUI update checks and local OSS provider detection constructed their own HTTP
clients instead of using Codex's shared client behavior.
What changed
retaining the existing default headers and custom CA fallback.
direct client and a per-request timeout.
system-proxy routing still reports certificate configuration errors.
Testing
Add coverage for local provider probes with invalid
CODEX_CA_CERTIFICATEandSSL_CERT_FILEvalues, and for custom CA fallback under both routing policies.