Clean up side conversations in the background - #35887
Merged
copyberry[bot] merged 1 commit intoJul 29, 2026
Merged
Conversation
## Why Switching away from a side conversation should not wait for its interrupt and unsubscribe requests to finish. ## What changed - Remove a side conversation from local TUI state immediately when switching threads, then interrupt and unsubscribe it in a background task. - Retry interruption with the active turn ID when the original turn races with cleanup. - Ignore late notifications and reject server requests for abandoned side conversations. ## Testing - Added coverage that background cleanup removes local state and ignores late events and approval requests. GitOrigin-RevId: 7a1d1c34f16ab023d1d1e235451b55404731190c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/7a1d1c34f16ab023d1d1e235451b55404731190c
branch
from
July 29, 2026 03:55
aabd4d7 to
d06c7ac
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/7a1d1c34f16ab023d1d1e235451b55404731190c
branch
July 29, 2026 03:56
JavierPiedra
temporarily deployed
to
issue-triage
July 29, 2026 05:26 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
JavierPiedra
temporarily deployed
to
issue-triage
July 29, 2026 05:26 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
JavierPiedra
temporarily deployed
to
issue-triage
July 29, 2026 05:26 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up side conversations in the background
Why
Switching away from a side conversation should not wait for its interrupt and
unsubscribe requests to finish.
What changed
threads, then interrupt and unsubscribe it in a background task.
cleanup.
conversations.
Testing
events and approval requests.