Resolve MCP file uploads with environment-native paths - #36002
Merged
copyberry[bot] merged 1 commit intoJul 29, 2026
Merged
Conversation
## Why File arguments for MCP app tools can use a path convention that differs from the host running Codex. Resolving those arguments with host-native path handling can therefore point uploads at the wrong file. ## What changed - Resolve file arguments against the selected turn environment's working directory with `PathUri::join`. - Use the resolved URI's inferred native spelling for errors and derive the uploaded filename without converting through a host-native path. ## Testing Run the existing MCP file upload integration test under Wine and reduce its streaming fixture to 2 MiB. GitOrigin-RevId: 0a659c19e73f5a26ddfc864e39dad6a4a404057b
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/0a659c19e73f5a26ddfc864e39dad6a4a404057b
branch
from
July 29, 2026 18:07
b51ba64 to
7579a2b
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/0a659c19e73f5a26ddfc864e39dad6a4a404057b
branch
July 29, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve MCP file uploads with environment-native paths
Why
File arguments for MCP app tools can use a path convention that differs from
the host running Codex. Resolving those arguments with host-native path handling
can therefore point uploads at the wrong file.
What changed
directory with
PathUri::join.uploaded filename without converting through a host-native path.
Testing
Run the existing MCP file upload integration test under Wine and reduce its
streaming fixture to 2 MiB.