Skip to content

Deny network access when an allow amendment fails - #36037

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/b2014d19128133abd5e19b8a7e4eb27810a45306
Jul 29, 2026
Merged

Deny network access when an allow amendment fails#36037
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/b2014d19128133abd5e19b8a7e4eb27810a45306

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deny network access when an allow amendment fails

Why

A failed network policy amendment must not grant access to the requested host or approve it for the rest of the session.

What changed

  • Only approve the host for the session after the allow amendment is applied successfully.
  • Otherwise deny the pending request and record a policy-denial outcome for its owning call.

Testing

Added a managed-network regression test that submits an invalid allow amendment, verifies that the request is blocked, and confirms that retrying the host prompts for approval again.

## Why

A failed network policy amendment must not grant access to the requested host or approve it for the rest of the session.

## What changed

- Only approve the host for the session after the allow amendment is applied successfully.
- Otherwise deny the pending request and record a policy-denial outcome for its owning call.

## Testing

Added a managed-network regression test that submits an invalid allow amendment, verifies that the request is blocked, and confirms that retrying the host prompts for approval again.

GitOrigin-RevId: b2014d19128133abd5e19b8a7e4eb27810a45306
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/b2014d19128133abd5e19b8a7e4eb27810a45306 branch from 5d78d11 to 3834c47 Compare July 29, 2026 22:30
@copyberry
copyberry Bot merged commit 3834c47 into main Jul 29, 2026
32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/b2014d19128133abd5e19b8a7e4eb27810a45306 branch July 29, 2026 22:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants