Preserve executor workspace permissions for apply_patch - #36133
Merged
copyberry[bot] merged 1 commit intoJul 30, 2026
Merged
Conversation
## What changed Build the `apply_patch` filesystem sandbox context from the executor's canonical permission profile instead of the execution attempt's materialized profile. Continue merging any additional permissions requested by the patch while keeping workspace roots scoped separately to the attempt. ## Testing - Update the sandbox-context test to verify that executor `workspace-write` permissions are preserved when attempt workspace roots and additional file permissions are present. GitOrigin-RevId: 2a9a8c2e1b1945e300283c400d0f1e573225a553
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2a9a8c2e1b1945e300283c400d0f1e573225a553
branch
from
July 30, 2026 11:12
228b0d6 to
bdda5da
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2a9a8c2e1b1945e300283c400d0f1e573225a553
branch
July 30, 2026 11:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve executor workspace permissions for apply_patch
What changed
Build the
apply_patchfilesystem sandbox context from the executor's canonical permission profile instead of the execution attempt's materialized profile. Continue merging any additional permissions requested by the patch while keeping workspace roots scoped separately to the attempt.Testing
workspace-writepermissions are preserved when attempt workspace roots and additional file permissions are present.