Use the step-scoped router for tool execution - #36357
Merged
copyberry[bot] merged 1 commit intoJul 31, 2026
Merged
Conversation
## Why Tool calls can outlive the sampling request that advertised them, so execution must retain the finalized tool plan for that specific step. ## What changed - Resolve tool runtimes, parallelism, cancellation behavior, argument diff consumers, and dispatch from the `ToolRouter` stored in `StepContext`. - Remove the separate router parameter from `ToolCallRuntime` and code-mode worker construction so callers cannot supply a different router. - Add a test helper for installing a router into a test `StepContext`. GitOrigin-RevId: 9e476ddd228ca5b1c03ed87863618ba77de6200c
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/9e476ddd228ca5b1c03ed87863618ba77de6200c
branch
from
July 31, 2026 16:24
165406c to
66ebeb7
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/9e476ddd228ca5b1c03ed87863618ba77de6200c
branch
July 31, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the step-scoped router for tool execution
Why
Tool calls can outlive the sampling request that advertised them, so execution
must retain the finalized tool plan for that specific step.
What changed
consumers, and dispatch from the
ToolRouterstored inStepContext.ToolCallRuntimeand code-modeworker construction so callers cannot supply a different router.
StepContext.