Avoid requesting key-release events in Ghostty - #36834
Merged
copyberry[bot] merged 1 commit intoAug 4, 2026
Merged
Conversation
## Why Ghostty can leak release events for shortcuts that the terminal consumes. ## What changed - Detect Ghostty when `TERM` is `xterm-ghostty`, including when `TERM_PROGRAM` is unavailable. - Omit `REPORT_EVENT_TYPES` from keyboard enhancement flags for Ghostty while retaining alternate-key and escape-code disambiguation reporting. ## Testing - Cover Ghostty detection through `TERM` and its keyboard enhancement flags. GitOrigin-RevId: d865a6cdd1373aad4b78099e821d1ebaeb6cfdff
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d865a6cdd1373aad4b78099e821d1ebaeb6cfdff
branch
from
August 4, 2026 03:50
7bc1009 to
db1a414
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d865a6cdd1373aad4b78099e821d1ebaeb6cfdff
branch
August 4, 2026 03:51
alexhopeoconnor
temporarily deployed
to
issue-triage
August 4, 2026 05:08 — with
GitHub Actions
Inactive
alexhopeoconnor
temporarily deployed
to
issue-triage
August 4, 2026 05:08 — with
GitHub Actions
Inactive
alexhopeoconnor
temporarily deployed
to
issue-triage
August 4, 2026 05:08 — with
GitHub Actions
Inactive
ecomclosekit
temporarily deployed
to
issue-triage
August 4, 2026 05:25 — with
GitHub Actions
Inactive
ecomclosekit
temporarily deployed
to
issue-triage
August 4, 2026 05:25 — with
GitHub Actions
Inactive
ecomclosekit
temporarily deployed
to
issue-triage
August 4, 2026 05:25 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid requesting key-release events in Ghostty
Why
Ghostty can leak release events for shortcuts that the terminal consumes.
What changed
TERMisxterm-ghostty, including whenTERM_PROGRAMis unavailable.REPORT_EVENT_TYPESfrom keyboard enhancement flags for Ghostty while retaining alternate-key and escape-code disambiguation reporting.Testing
TERMand its keyboard enhancement flags.