Skip to content

Avoid requesting key-release events in Ghostty - #36834

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d865a6cdd1373aad4b78099e821d1ebaeb6cfdff
Aug 4, 2026
Merged

Avoid requesting key-release events in Ghostty#36834
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/d865a6cdd1373aad4b78099e821d1ebaeb6cfdff

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 4, 2026

Copy link
Copy Markdown

Avoid requesting key-release events in Ghostty

Why

Ghostty can leak release events for shortcuts that the terminal consumes.

What changed

  • Detect Ghostty when TERM is xterm-ghostty, including when TERM_PROGRAM is unavailable.
  • Omit REPORT_EVENT_TYPES from keyboard enhancement flags for Ghostty while retaining alternate-key and escape-code disambiguation reporting.

Testing

  • Cover Ghostty detection through TERM and its keyboard enhancement flags.

## Why

Ghostty can leak release events for shortcuts that the terminal consumes.

## What changed

- Detect Ghostty when `TERM` is `xterm-ghostty`, including when `TERM_PROGRAM` is unavailable.
- Omit `REPORT_EVENT_TYPES` from keyboard enhancement flags for Ghostty while retaining alternate-key and escape-code disambiguation reporting.

## Testing

- Cover Ghostty detection through `TERM` and its keyboard enhancement flags.

GitOrigin-RevId: d865a6cdd1373aad4b78099e821d1ebaeb6cfdff
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/d865a6cdd1373aad4b78099e821d1ebaeb6cfdff branch from 7bc1009 to db1a414 Compare August 4, 2026 03:50
@copyberry
copyberry Bot merged commit db1a414 into main Aug 4, 2026
30 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/d865a6cdd1373aad4b78099e821d1ebaeb6cfdff branch August 4, 2026 03:51
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants