Redact secrets from app-server command execution items - #36893
Merged
copyberry[bot] merged 1 commit intoAug 4, 2026
Merged
Conversation
## Why Client-facing command execution items can include recognizable secrets in the rendered command or parsed command actions. ## What changed - Redact secrets in `commandExecution.command` and `commandActions` for live items, completed items, and replayed thread history. - Keep command approval requests backed by the original executable command and parsed actions while using the redacted representation for display items. - Document that execution item commands are redacted display values rather than executable commands. ## Testing - Cover redaction for command conversion, parsed search actions, legacy replay, approval flows, completion notifications, and rejected commands. GitOrigin-RevId: 2ad056f21882bf5166182ad1a4ff0bf6471d9c0e
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2ad056f21882bf5166182ad1a4ff0bf6471d9c0e
branch
from
August 4, 2026 13:18
5e16bfa to
fcf636a
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2ad056f21882bf5166182ad1a4ff0bf6471d9c0e
branch
August 4, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redact secrets from app-server command execution items
Why
Client-facing command execution items can include recognizable secrets in the
rendered command or parsed command actions.
What changed
commandExecution.commandandcommandActionsfor liveitems, completed items, and replayed thread history.
parsed actions while using the redacted representation for display items.
executable commands.
Testing
approval flows, completion notifications, and rejected commands.