Accept user input when starting idle turns - #36947
Merged
copyberry[bot] merged 1 commit intoAug 4, 2026
Merged
Conversation
## What changed - Generalize `CodexThread::try_start_turn_if_idle` to accept exported `TurnInput` values, preserving user content and client IDs in the first model request. - Allow non-empty user input to start an idle turn in Plan mode while retaining the Plan-mode rejection for automatic response items and empty user input. - Process idle user input through the normal user-turn path so connector selections are cleared, prompt telemetry is recorded, and referenced skill instructions are included. ## Testing - Cover idle user input in Default and Plan modes, response-item mailbox merging, empty-input rejection, and skill instruction injection. GitOrigin-RevId: 116667d160d4464b525d9e4c7e8cc05d23a94008
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/116667d160d4464b525d9e4c7e8cc05d23a94008
branch
from
August 4, 2026 18:52
6f63262 to
989a0b0
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/116667d160d4464b525d9e4c7e8cc05d23a94008
branch
August 4, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept user input when starting idle turns
What changed
CodexThread::try_start_turn_if_idleto accept exportedTurnInputvalues, preserving user content and client IDs in the first modelrequest.
the Plan-mode rejection for automatic response items and empty user input.
selections are cleared, prompt telemetry is recorded, and referenced skill
instructions are included.
Testing
merging, empty-input rejection, and skill instruction injection.