Allow injecting model catalog caches - #36992
Merged
copyberry[bot] merged 1 commit intoAug 4, 2026
Merged
Conversation
## What changed - Add the public asynchronous `ModelsCache` contract and cache entry/error types. - Let model providers and `OpenAiModelsManager` accept caller-provided cache implementations while retaining the existing file-backed cache by default. - Treat cache read failures as misses, keep cache write failures non-fatal, and support refreshing an entry's TTL after ETag revalidation. - Continue to prefer an explicitly configured static model catalog over an injected cache. ## Testing - Cover injected cache hits, read and write failures, TTL refreshes, and end-to-end model selection. - Verify that the file-backed implementation satisfies the new cache contract and does not serve expired entries before revalidation. GitOrigin-RevId: eef957a317910b8502a0c20f8fc112f689d5e389
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/eef957a317910b8502a0c20f8fc112f689d5e389
branch
from
August 4, 2026 23:04
b701286 to
44cb66e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/eef957a317910b8502a0c20f8fc112f689d5e389
branch
August 4, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow injecting model catalog caches
What changed
ModelsCachecontract and cache entry/error types.OpenAiModelsManageraccept caller-provided cache implementations while retaining the existing file-backed cache by default.Testing