Skip to content

Bound interactive telemetry shutdown - #37109

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/5b5f31a841fbc5788715cb3065d522c6dafa994f
Aug 5, 2026
Merged

Bound interactive telemetry shutdown#37109
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/5b5f31a841fbc5788715cb3065d522c6dafa994f

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 5, 2026

Copy link
Copy Markdown

Bound interactive telemetry shutdown

Why

A stalled telemetry exporter can block shutdown indefinitely when the interactive TUI exits.

What changed

  • Add OtelProvider::shutdown_with_timeout to run exporter shutdown on a detached thread and report completion, worker failure, or timeout.
  • Give interactive TUI telemetry shutdown a 500 ms time budget and warn if cleanup does not finish successfully.

Testing

  • Cover successful shutdown on current-thread and multi-thread Tokio runtimes, worker creation failure, and timeout behavior.
  • Verify that OTLP HTTP shutdown returns on time when a collector stalls.

## Why

A stalled telemetry exporter can block shutdown indefinitely when the interactive TUI exits.

## What changed

- Add `OtelProvider::shutdown_with_timeout` to run exporter shutdown on a detached thread and report completion, worker failure, or timeout.
- Give interactive TUI telemetry shutdown a 500 ms time budget and warn if cleanup does not finish successfully.

## Testing

- Cover successful shutdown on current-thread and multi-thread Tokio runtimes, worker creation failure, and timeout behavior.
- Verify that OTLP HTTP shutdown returns on time when a collector stalls.

GitOrigin-RevId: 5b5f31a841fbc5788715cb3065d522c6dafa994f
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/5b5f31a841fbc5788715cb3065d522c6dafa994f branch from ddb6eaf to 2707dfc Compare August 5, 2026 15:21
@copyberry
copyberry Bot merged commit 2707dfc into main Aug 5, 2026
29 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/5b5f31a841fbc5788715cb3065d522c6dafa994f branch August 5, 2026 15:22
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants