Make Windows path URI comparisons ASCII-case-insensitive - #37129
Merged
copyberry[bot] merged 1 commit intoAug 5, 2026
Merged
Conversation
## What changed - Make `PathUri` equality and hashing ignore ASCII case for inferred Windows drive and UNC paths while preserving case-sensitive POSIX behavior. - Apply the same convention-aware comparison to `starts_with` and `relative_path_from`, including equivalent percent-encoded path spellings. - Continue to fail closed for encoded path separators, opaque fallback URIs, and non-ASCII case differences. ## Testing - Add unit coverage for equality and hash consistency, Windows containment and relative paths, POSIX case sensitivity, encoded separators, and non-ASCII case differences. GitOrigin-RevId: cd828874686a9cd242a36262ee3e7a9a172bd5b7
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/cd828874686a9cd242a36262ee3e7a9a172bd5b7
branch
from
August 5, 2026 17:56
61ee139 to
4cb8676
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/cd828874686a9cd242a36262ee3e7a9a172bd5b7
branch
August 5, 2026 17:57
aneustadt22
temporarily deployed
to
issue-triage
August 5, 2026 18:04 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
aneustadt22
temporarily deployed
to
issue-triage
August 5, 2026 18:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
aneustadt22
temporarily deployed
to
issue-triage
August 5, 2026 18:04 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Windows path URI comparisons ASCII-case-insensitive
What changed
PathUriequality and hashing ignore ASCII case for inferred Windowsdrive and UNC paths while preserving case-sensitive POSIX behavior.
starts_withandrelative_path_from, including equivalent percent-encoded path spellings.and non-ASCII case differences.
Testing
relative paths, POSIX case sensitivity, encoded separators, and non-ASCII
case differences.