Move explicit skill selection into the skills crate - #37177
Merged
copyberry[bot] merged 1 commit intoAug 5, 2026
Merged
Conversation
## What changed - Add `ExplicitSkillLookup` to decouple explicit mention selection from the core skill-loading model. - Export `collect_explicit_skill_mentions` from `codex-skills` and implement the lookup interface for `SkillLoadOutcome`. - Move the selection tests into `codex-skills` while keeping the prompt-size boundary test with prompt injection. GitOrigin-RevId: 21105af31c9b519c231c5ea02464da560705c293
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/21105af31c9b519c231c5ea02464da560705c293
branch
from
August 5, 2026 23:24
c7f41c8 to
a3ebd19
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/21105af31c9b519c231c5ea02464da560705c293
branch
August 5, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move explicit skill selection into the skills crate
What changed
ExplicitSkillLookupto decouple explicit mention selection from thecore skill-loading model.
collect_explicit_skill_mentionsfromcodex-skillsand implementthe lookup interface for
SkillLoadOutcome.codex-skillswhile keeping the prompt-sizeboundary test with prompt injection.