Fully repaint inline viewports after history overlap - #37335
Merged
copyberry[bot] merged 1 commit intoAug 7, 2026
Merged
Conversation
## Why During inline-mode resize reflow, replayed history can overlap a zero- or one-row history region and leave stale terminal characters visible in the composer. Resetting the previous render buffer is insufficient because default-style spaces may still compare equal and be skipped. ## What changed - Mark every cell in an invalidated viewport for unconditional repainting. - Invalidate the viewport after flushing pending history when history can overlap it. ## Testing Add regression coverage for repainting spaces over stale cells and a manual `tmux` resize smoke test for preserving visible multiline draft text. GitOrigin-RevId: 5a8a480e2fc50c801561de6a4598a3ab8c12b8d6
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/5a8a480e2fc50c801561de6a4598a3ab8c12b8d6
branch
from
August 7, 2026 00:05
af5b573 to
303a292
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/5a8a480e2fc50c801561de6a4598a3ab8c12b8d6
branch
August 7, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully repaint inline viewports after history overlap
Why
During inline-mode resize reflow, replayed history can overlap a zero- or
one-row history region and leave stale terminal characters visible in the
composer. Resetting the previous render buffer is insufficient because
default-style spaces may still compare equal and be skipped.
What changed
overlap it.
Testing
Add regression coverage for repainting spaces over stale cells and a manual
tmuxresize smoke test for preserving visible multiline draft text.