Add shared skill root loading interfaces - #37439
Merged
copyberry[bot] merged 1 commit intoAug 7, 2026
Merged
Conversation
## What changed - Add `SkillRootLoader` and its request/result types to `codex-skills` so skill roots can be loaded through a shared, object-safe interface. - Add owner-managed snapshot cache handles that support reuse and use cache allocation identity for equality and hashing. - Move `SkillError` into `codex-skills` and re-export the new loading API. ## Testing - Verify snapshot sharing and identity semantics. - Verify loaders can be used as shared trait objects. GitOrigin-RevId: a26a8101008a6c862824a7346cdbe6d05f4bcc01
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a26a8101008a6c862824a7346cdbe6d05f4bcc01
branch
from
August 7, 2026 12:48
64c7021 to
a4b129e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a26a8101008a6c862824a7346cdbe6d05f4bcc01
branch
August 7, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add shared skill root loading interfaces
What changed
SkillRootLoaderand its request/result types tocodex-skillsso skill roots can be loaded through a shared, object-safe interface.SkillErrorintocodex-skillsand re-export the new loading API.Testing