Skip to content

Enforce automatic review for managed models - #37511

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c4b1d52c3b5b75e86880725412b8f0812e0dfcd9
Aug 7, 2026
Merged

Enforce automatic review for managed models#37511
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/c4b1d52c3b5b75e86880725412b8f0812e0dfcd9

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 7, 2026

Copy link
Copy Markdown

Enforce automatic review for managed models

What changed

  • Add the managed auto_review.required_on_models requirement, unioning model slugs across requirement layers and exposing the result through configRequirements/read.
  • Force listed models to use on-request approvals with the auto_review reviewer. Downgrade Full Access to workspace-write when starting a protected session, and reject incompatible runtime overrides or use when automatic review is disabled.
  • Preserve these protections across thread starts, resumes, forks, model changes, turn overrides, MCP approvals, and TUI session attachment.

Testing

  • Add coverage for layered model requirements and exact provider-alias matching.
  • Add app-server tests for protected thread lifecycle operations, unsafe setting overrides, legacy thread upgrades, disabled automatic review, and requirements API output.

## What changed

- Add the managed `auto_review.required_on_models` requirement, unioning model slugs across requirement layers and exposing the result through `configRequirements/read`.
- Force listed models to use `on-request` approvals with the `auto_review` reviewer. Downgrade Full Access to workspace-write when starting a protected session, and reject incompatible runtime overrides or use when automatic review is disabled.
- Preserve these protections across thread starts, resumes, forks, model changes, turn overrides, MCP approvals, and TUI session attachment.

## Testing

- Add coverage for layered model requirements and exact provider-alias matching.
- Add app-server tests for protected thread lifecycle operations, unsafe setting overrides, legacy thread upgrades, disabled automatic review, and requirements API output.

GitOrigin-RevId: c4b1d52c3b5b75e86880725412b8f0812e0dfcd9
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/c4b1d52c3b5b75e86880725412b8f0812e0dfcd9 branch from d9b4ca1 to 208f05b Compare August 7, 2026 23:44
@copyberry
copyberry Bot merged commit 208f05b into main Aug 7, 2026
29 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/c4b1d52c3b5b75e86880725412b8f0812e0dfcd9 branch August 7, 2026 23:45
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant