Add a feature flag to preserve apply_patch line endings - #37758
Merged
copyberry[bot] merged 1 commit intoAug 10, 2026
Merged
Conversation
## What changed - Add the `apply_patch_preserve_line_endings` feature, disabled by default, to preserve CRLF, CR, and mixed line endings when `apply_patch` updates files. - Apply the feature consistently to built-in patch handling and patches invoked through shell, user-shell, unified-exec, and app-server command execution. - Keep the active feature configuration authoritative over inherited, shell snapshot, and client-provided environment values. ## Testing - Cover line-ending behavior with the feature enabled and disabled for custom tool calls, shell heredocs, command execution, and the `apply_patch` CLI. GitOrigin-RevId: 531a7c66761959c650270559f57941929f03e6c4
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/531a7c66761959c650270559f57941929f03e6c4
branch
from
August 10, 2026 01:45
10a6925 to
c9c6c0d
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/531a7c66761959c650270559f57941929f03e6c4
branch
August 10, 2026 01:46
markneumann
temporarily deployed
to
issue-triage
August 10, 2026 02:27 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
markneumann
temporarily deployed
to
issue-triage
August 10, 2026 02:27 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
markneumann
temporarily deployed
to
issue-triage
August 10, 2026 02:27 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
markneumann
temporarily deployed
to
issue-triage
August 10, 2026 02:29 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
M1nt-Ch0c0
temporarily deployed
to
issue-triage
August 10, 2026 02:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
M1nt-Ch0c0
temporarily deployed
to
issue-triage
August 10, 2026 02:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
M1nt-Ch0c0
temporarily deployed
to
issue-triage
August 10, 2026 02:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a feature flag to preserve apply_patch line endings
What changed
apply_patch_preserve_line_endingsfeature, disabled by default, topreserve CRLF, CR, and mixed line endings when
apply_patchupdates files.through shell, user-shell, unified-exec, and app-server command execution.
snapshot, and client-provided environment values.
Testing
tool calls, shell heredocs, command execution, and the
apply_patchCLI.