Speed up MCP OAuth credential reads - #37842
Merged
copyberry[bot] merged 1 commit intoAug 10, 2026
Merged
Conversation
## Why Concurrent MCP startup and status checks should not serialize when they only read the shared credential store. Repeated reads of the encrypted MCP OAuth store also needlessly decrypted unchanged contents. ## What changed - Use shared locks for `File` and `Secrets` credential reads while keeping saves and deletes exclusive. - Cache decrypted MCP OAuth secrets by store path, ciphertext, and passphrase, and invalidate the cache after writes. ## Testing - Cover concurrent readers, reader/writer exclusion, shared credential loads, and cache invalidation after updates and deletes. GitOrigin-RevId: f13512e6404d4919879ba5ba77a3e34e52b35640
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/f13512e6404d4919879ba5ba77a3e34e52b35640
branch
from
August 10, 2026 15:44
9e6f1f2 to
8b1b065
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/f13512e6404d4919879ba5ba77a3e34e52b35640
branch
August 10, 2026 15:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up MCP OAuth credential reads
Why
Concurrent MCP startup and status checks should not serialize when they only read the shared credential store. Repeated reads of the encrypted MCP OAuth store also needlessly decrypted unchanged contents.
What changed
FileandSecretscredential reads while keeping saves and deletes exclusive.Testing