Skip to content

Route intercepted exec approvals through shared review - #37851

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e6cccf160637e4246aff4714c22f08c90b65306d
Aug 10, 2026
Merged

Route intercepted exec approvals through shared review#37851
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/e6cccf160637e4246aff4714c22f08c90b65306d

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 10, 2026

Copy link
Copy Markdown

Route intercepted exec approvals through shared review

What changed

  • Send Unix execve approvals intercepted by the zsh fork through the shared approval pipeline, including permission hooks, Guardian review, user prompts, and telemetry.
  • Resolve the active turn and its auto-review setting when an intercepted command needs approval, so commands sent to persistent terminals use the current turn's reviewer.
  • Give each intercepted command a distinct approval ID and propagate an aborted approval as a turn abort.

Testing

  • Cover Guardian review for intercepted unified_exec commands and persistent terminals across turns.
  • Verify repeated identical intercepted commands receive separate user approvals.

## What changed

- Send Unix `execve` approvals intercepted by the zsh fork through the shared approval pipeline, including permission hooks, Guardian review, user prompts, and telemetry.
- Resolve the active turn and its auto-review setting when an intercepted command needs approval, so commands sent to persistent terminals use the current turn's reviewer.
- Give each intercepted command a distinct approval ID and propagate an aborted approval as a turn abort.

## Testing

- Cover Guardian review for intercepted `unified_exec` commands and persistent terminals across turns.
- Verify repeated identical intercepted commands receive separate user approvals.

GitOrigin-RevId: e6cccf160637e4246aff4714c22f08c90b65306d
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/e6cccf160637e4246aff4714c22f08c90b65306d branch from f56ffd0 to d06dc73 Compare August 10, 2026 17:26
@copyberry
copyberry Bot merged commit d06dc73 into main Aug 10, 2026
30 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/e6cccf160637e4246aff4714c22f08c90b65306d branch August 10, 2026 17:27
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants