Route intercepted exec approvals through shared review - #37851
Merged
copyberry[bot] merged 1 commit intoAug 10, 2026
Merged
Conversation
## What changed - Send Unix `execve` approvals intercepted by the zsh fork through the shared approval pipeline, including permission hooks, Guardian review, user prompts, and telemetry. - Resolve the active turn and its auto-review setting when an intercepted command needs approval, so commands sent to persistent terminals use the current turn's reviewer. - Give each intercepted command a distinct approval ID and propagate an aborted approval as a turn abort. ## Testing - Cover Guardian review for intercepted `unified_exec` commands and persistent terminals across turns. - Verify repeated identical intercepted commands receive separate user approvals. GitOrigin-RevId: e6cccf160637e4246aff4714c22f08c90b65306d
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e6cccf160637e4246aff4714c22f08c90b65306d
branch
from
August 10, 2026 17:26
f56ffd0 to
d06dc73
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e6cccf160637e4246aff4714c22f08c90b65306d
branch
August 10, 2026 17:27
sergioguerramx
temporarily deployed
to
issue-triage
August 10, 2026 17:31 — with
GitHub Actions
Inactive
sergioguerramx
temporarily deployed
to
issue-triage
August 10, 2026 17:31 — with
GitHub Actions
Inactive
sergioguerramx
temporarily deployed
to
issue-triage
August 10, 2026 17:31 — with
GitHub Actions
Inactive
VincentStella888
temporarily deployed
to
issue-triage
August 10, 2026 17:36 — with
GitHub Actions
Inactive
VincentStella888
temporarily deployed
to
issue-triage
August 10, 2026 17:36 — with
GitHub Actions
Inactive
VincentStella888
temporarily deployed
to
issue-triage
August 10, 2026 17:36 — with
GitHub Actions
Inactive
xiao345882974-blip
temporarily deployed
to
issue-triage
August 10, 2026 17:41 — with
GitHub Actions
Inactive
xiao345882974-blip
temporarily deployed
to
issue-triage
August 10, 2026 17:41 — with
GitHub Actions
Inactive
xiao345882974-blip
temporarily deployed
to
issue-triage
August 10, 2026 17:41 — with
GitHub Actions
Inactive
RaviTharuma
temporarily deployed
to
issue-triage
August 10, 2026 17:51 — with
GitHub Actions
Inactive
RaviTharuma
temporarily deployed
to
issue-triage
August 10, 2026 17:51 — with
GitHub Actions
Inactive
RaviTharuma
temporarily deployed
to
issue-triage
August 10, 2026 17:51 — with
GitHub Actions
Inactive
RaviTharuma
temporarily deployed
to
issue-triage
August 10, 2026 17:52 — with
GitHub Actions
Inactive
RaviTharuma
temporarily deployed
to
issue-triage
August 10, 2026 17:52 — with
GitHub Actions
Inactive
RaviTharuma
temporarily deployed
to
issue-triage
August 10, 2026 17:52 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route intercepted exec approvals through shared review
What changed
execveapprovals intercepted by the zsh fork through the shared approval pipeline, including permission hooks, Guardian review, user prompts, and telemetry.Testing
unified_execcommands and persistent terminals across turns.